HDDS-4623. Update CountQuota to NamesapceQuota#1735
Merged
captainzmc merged 4 commits intoapache:masterfrom Dec 28, 2020
Merged
HDDS-4623. Update CountQuota to NamesapceQuota#1735captainzmc merged 4 commits intoapache:masterfrom
captainzmc merged 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
R: @captainzmc |
captainzmc
reviewed
Dec 25, 2020
Member
captainzmc
left a comment
captainzmc
left a comment
There was a problem hiding this comment.
Thanks for the update. LGTM overall, just some minor comments. You can also check if there are any other modifications needed.
| * @throws IOException | ||
| */ | ||
| public void clearCountQuota() throws IOException { | ||
| public void clearNamespaceQuota() throws IOException { |
| * @throws IOException | ||
| */ | ||
| public void clearCountQuota() throws IOException { | ||
| public void clearNamespaceQuota() throws IOException { |
Member
There was a problem hiding this comment.
The method description also needs to be update.
Contributor
Author
|
comments addressed. |
ayushtkn
approved these changes
Dec 28, 2020
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
I tried to find any other usage of count quota, but couldn't find any.
Changes LGTM
captainzmc
approved these changes
Dec 28, 2020
Member
captainzmc
left a comment
captainzmc
left a comment
There was a problem hiding this comment.
LGTM +1. Thanks for @amaliujia's patch and @ayushtkn's review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use more description words "namespace quota" to replace "count quota".
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4623
How was this patch tested?
UT