HDDS-4672. Add warning log when old volume and bucket set quota#1781
HDDS-4672. Add warning log when old volume and bucket set quota#1781ChenSammi merged 3 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
nit: better to undo this line of change.
There was a problem hiding this comment.
I feel like "old" does not provide enough context.
Will it better to say that " {} is a volume created before version 1.1.0"? Same for the following warning messages.
There was a problem hiding this comment.
Can we pass this warnning message to client side? Put it in log is not enough to raise the alert to user.
There was a problem hiding this comment.
Yes, the warning here is pass to the user client directly. Users can see this whether they're using shell or API.
There was a problem hiding this comment.
@captainzmc ， we can see this output on console because LOG is enabled. When LOG is disabled on client side, we cannot see any message. My suggestion is we return this message as the command response, and then output to console.
|
overall LGTM |
|
Had added message as the command response, and output to console. CI runs normally on my personal branch. |
captainzmc
force-pushed
the
add-warn-quota
branch
from
59b2646 to
855d11b
Compare
captainzmc
force-pushed
the
add-warn-quota
branch
from
2f55615 to
588013f
Compare
|
+1 |
3 participants
What changes were proposed in this pull request?
https://github.com/apache/ozone/blob/master/hadoop-hdds/docs/content/feature/Quota.md
Currently we only advise users in the doc document not to enable quota for old volumes and buckets. Sometimes the user might not notice. So we added a warning on the client side, when user set quota on old volume and bucket.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4672
How was this patch tested?
Add log no need UT