HDDS-4593. Refine IAccessAuthorizer interface to do recursive ACL check on a path#1790
HDDS-4593. Refine IAccessAuthorizer interface to do recursive ACL check on a path#1790rakeshadr merged 6 commits intoapache:masterfrom
Conversation
mukul1987
left a comment
There was a problem hiding this comment.
I think we also need changes to use or set the resrusiveAccessCheck flag in our code. Will that be covered as part of another patch ?
Thanks @mukul1987 for the reviews. This PR is targeting to the master branch and I am planning to do the recursiveCheck=true on the feature branch code. Once this PR is merged then I will rebase the feature branch with master and then will do the settings along with HDDS-4691 task. Hope this makes sense to you. |
Thanks @xiaoyuyao for the reviews. CI failure is unrelated to the patch, anyway I've triggered another build. |
|
Thank you @mukul1987 , @xiaoyuyao for the reviews! |
What changes were proposed in this pull request?
The idea/proposal is to refine #checkAccess interface by giving "recursive" hint and make only one single call during recursive delete or list operations. Now, the implementation classes(native or external entity) can do recursive logic in an optimized way.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4593
How was this patch tested?
Modified existing UTs to check the flag values. Will add more test cases along with atomic delete ops.