Skip to content

HDDS-4593. Refine IAccessAuthorizer interface to do recursive ACL check on a path#1790

Merged
rakeshadr merged 6 commits intoapache:masterfrom
rakeshadr:HDDS-4593
Jan 20, 2021
Merged

HDDS-4593. Refine IAccessAuthorizer interface to do recursive ACL check on a path#1790
rakeshadr merged 6 commits intoapache:masterfrom
rakeshadr:HDDS-4593

Conversation

@rakeshadr
Copy link
Contributor

What changes were proposed in this pull request?

The idea/proposal is to refine #checkAccess interface by giving "recursive" hint and make only one single call during recursive delete or list operations. Now, the implementation classes(native or external entity) can do recursive logic in an optimized way.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4593

How was this patch tested?

Modified existing UTs to check the flag values. Will add more test cases along with atomic delete ops.

Copy link
Contributor

@mukul1987 mukul1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need changes to use or set the resrusiveAccessCheck flag in our code. Will that be covered as part of another patch ?

@rakeshadr
Copy link
Contributor Author

I think we also need changes to use or set the resrusiveAccessCheck flag in our code. Will that be covered as part of another patch ?

Thanks @mukul1987 for the reviews. This PR is targeting to the master branch and I am planning to do the recursiveCheck=true on the feature branch code. Once this PR is merged then I will rebase the feature branch with master and then will do the settings along with HDDS-4691 task.

Hope this makes sense to you.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 pending CI.

@rakeshadr
Copy link
Contributor Author

LGTM, +1 pending CI.

Thanks @xiaoyuyao for the reviews. CI failure is unrelated to the patch, anyway I've triggered another build.
I could see HDDS-4693 is raised to fix TestContainerStateMachine failure.

@rakeshadr rakeshadr merged commit 026c625 into apache:master Jan 20, 2021
@rakeshadr
Copy link
Contributor Author

Thank you @mukul1987 , @xiaoyuyao for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments