HDDS-4760. Intermittent failure in ozone-ha acceptance test#1886
Merged
adoroszlai merged 2 commits intoapache:masterfrom Feb 6, 2021
Merged
HDDS-4760. Intermittent failure in ozone-ha acceptance test#1886adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
requested review from
bharatviswa504,
elek,
hanishakoneru and
sodonnel
sodonnel
approved these changes
Feb 5, 2021
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM. Hopefully this will work better than a set number of retries.
Contributor
Author
|
Thanks @sodonnel for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Wait for OM leader election (similar to SCM safemode exit) in acceptance tests, as even 15 retries is not enough in some cases (failover to other OM has no delay).
https://issues.apache.org/jira/browse/HDDS-4760
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/actions/runs/531562574