HDDS-4792. Remove redundant state check for handleDeleteChunk#1894
Merged
elek merged 1 commit intoapache:masterfrom Mar 19, 2021
Merged
HDDS-4792. Remove redundant state check for handleDeleteChunk#1894elek merged 1 commit intoapache:masterfrom
elek merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@elek @adoroszlai Could you help to review this PR? Thanks in advance. |
ayushtkn
reviewed
Feb 9, 2021
| checkContainerIsHealthy(kvContainer); | ||
| } catch (StorageContainerException sce) { | ||
| return ContainerUtils.logAndReturnError(LOG, sce, request); | ||
| } |
Member
There was a problem hiding this comment.
Where is this check available in handleDeleteChunk path? I tried checking callers of the method, couldn't find where this is checked before. Can you point me to that
Contributor
Author
There was a problem hiding this comment.
Sorry, I didn't get the question? Do you mean where the function is called before?
Contributor
Author
There was a problem hiding this comment.
I didn't find the usage of DeleteChunk either.
I think the method of deleteChunk in ChunkManager is designed for FilePerChunkStrategy first that it will only delete one chunk file, in FilePerBlockStrategy the method should throw the exception of unsupported request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4792
How was this patch tested?
Locally test.