Skip to content

HDDS-4794. No appenders could be found for logger - in tests#1896

Merged
adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai:HDDS-4794
Feb 8, 2021
Merged

HDDS-4794. No appenders could be found for logger - in tests#1896
adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai:HDDS-4794

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Unit tests in some submodules only output:

log4j:WARN No appenders could be found for logger (org.apache.hadoop.hdds.utils.db.RDBStore).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.

Adding log4j.properties to fix it.

https://issues.apache.org/jira/browse/HDDS-4794

How was this patch tested?

Checked which tests were affected:
https://github.com/adoroszlai/hadoop-ozone/runs/1834026205#step:4:1

And that no test had the problem with the fix:
https://github.com/adoroszlai/hadoop-ozone/runs/1834329207#step:4:1

@adoroszlai adoroszlai self-assigned this Feb 5, 2021
@lamberken
Copy link
Member

lamberken commented Feb 7, 2021

👍 seems that we can remove log4j.threshold=ALL.

ALL includes INFO, and if using following config properties, TRACE, DEBUG logs will not console to stdout.

log4j.rootLogger=INFO,stdout
log4j.threshold=ALL

Copy link
Contributor

@swagle swagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@adoroszlai adoroszlai merged commit 71b8bdd into apache:master Feb 8, 2021
@adoroszlai adoroszlai deleted the HDDS-4794 branch February 8, 2021 20:27
@adoroszlai
Copy link
Contributor Author

Thanks @lamber-ken and @swagle for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants