HDDS-4801. Skip coverage check for PRs and in forks#1909
Merged
elek merged 1 commit intoapache:masterfrom Feb 9, 2021
Merged
Conversation
elek
approved these changes
Feb 9, 2021
Member
elek
left a comment
There was a problem hiding this comment.
+1 I am fine with disabling it.
I have never had any plan to do something with the coverage data, but when I read the description of this PR I had an idea ;-) : it would be easy to create a Github actions scripts to compare the coverage artifacts between PR and master and create a report.
But we can turn it back anytime when we will have useful usage...
Contributor
Author
That's also what Codecov was supposed to do, but it had been disabled earlier due to unreliability. |
Contributor
Author
|
Thanks @elek for reviewing and committing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently coverage CI check:
Thus for PR in Apache Ozone and for all builds in forks, it only stores coverage in the artifact. These expire in 30 days and I don't think anybody really checks them manually.
I propose to completely skip coverage check for PRs and in forks, instead of only skipping upload to Sonar. This would save ~12 minutes for such builds.
https://issues.apache.org/jira/browse/HDDS-4801
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/1849668371