Skip to content

HDDS-4801. Skip coverage check for PRs and in forks#1909

Merged
elek merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-4801
Feb 9, 2021
Merged

HDDS-4801. Skip coverage check for PRs and in forks#1909
elek merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-4801

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Currently coverage CI check:

  1. calculates combined test coverage
  2. uploads it to Sonar only for Apache Ozone repo and only for builds on push/schedule
  3. stores combined coverage in GitHub Actions artifact

Thus for PR in Apache Ozone and for all builds in forks, it only stores coverage in the artifact. These expire in 30 days and I don't think anybody really checks them manually.

I propose to completely skip coverage check for PRs and in forks, instead of only skipping upload to Sonar. This would save ~12 minutes for such builds.

https://issues.apache.org/jira/browse/HDDS-4801

How was this patch tested?

https://github.com/adoroszlai/hadoop-ozone/runs/1849668371

@adoroszlai adoroszlai self-assigned this Feb 8, 2021
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I am fine with disabling it.

I have never had any plan to do something with the coverage data, but when I read the description of this PR I had an idea ;-) : it would be easy to create a Github actions scripts to compare the coverage artifacts between PR and master and create a report.

But we can turn it back anytime when we will have useful usage...

@elek elek merged commit 19d115d into apache:master Feb 9, 2021
@adoroszlai
Copy link
Contributor Author

it would be easy to create a Github actions scripts to compare the coverage artifacts between PR and master and create a report.

That's also what Codecov was supposed to do, but it had been disabled earlier due to unreliability.

@adoroszlai
Copy link
Contributor Author

Thanks @elek for reviewing and committing it.

@adoroszlai adoroszlai deleted the HDDS-4801 branch February 9, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants