HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION#1946
Merged
swagle merged 2 commits intoapache:masterfrom Feb 19, 2021
Merged
HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION#1946swagle merged 2 commits intoapache:masterfrom
swagle merged 2 commits intoapache:masterfrom
Conversation
avijayanhwx
approved these changes
Feb 19, 2021
Contributor
avijayanhwx
left a comment
There was a problem hiding this comment.
LGTM +1. One minor qn inline.
Contributor
|
Thanks for the review @avijayanhwx committing this change. |
Contributor
Author
|
Thanks @avijayanhwx and @swagle for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-4731 missed some places related to file status where client version needs to be considered for protobuf conversion. These can be reproduced by
ozone fsoperations:https://issues.apache.org/jira/browse/HDDS-4851
How was this patch tested?
Added acceptance test cases. 0.5.0 client had to be removed from the test due to another incompatibility: