Skip to content

HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION#1946

Merged
swagle merged 2 commits intoapache:masterfrom
adoroszlai:HDDS-4851
Feb 19, 2021
Merged

HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION#1946
swagle merged 2 commits intoapache:masterfrom
adoroszlai:HDDS-4851

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-4731 missed some places related to file status where client version needs to be considered for protobuf conversion. These can be reproduced by ozone fs operations:

$ ozone fs -mkdir o3fs://bucket1.vol1/dir/
$ ozone fs -ls o3fs://bucket1.vol1/dir/
$ ozone fs -put /etc/passwd o3fs://bucket1.vol1/dir/
-put: No enum constant org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name.REPLICATION
$ ozone fs -ls o3fs://bucket1.vol1/dir/
-ls: No enum constant org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name.REPLICATION

https://issues.apache.org/jira/browse/HDDS-4851

How was this patch tested?

Added acceptance test cases. 0.5.0 client had to be removed from the test due to another incompatibility:

Message missing required fields: getFileStatusResponse.status.status, ...

@adoroszlai adoroszlai self-assigned this Feb 19, 2021
@adoroszlai adoroszlai added bug Something isn't working compatibility labels Feb 19, 2021
Copy link
Contributor

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1. One minor qn inline.

@swagle
Copy link
Contributor

swagle commented Feb 19, 2021

Thanks for the review @avijayanhwx committing this change.

@swagle swagle merged commit 2c53c82 into apache:master Feb 19, 2021
@adoroszlai
Copy link
Contributor Author

Thanks @avijayanhwx and @swagle for the review.

@adoroszlai adoroszlai deleted the HDDS-4851 branch February 20, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants