HDDS-4683. [FSO]ListKeys: do lookup in dir and file tables#1954
Merged
rakeshadr merged 6 commits intoapache:HDDS-2939from Feb 26, 2021
Merged
HDDS-4683. [FSO]ListKeys: do lookup in dir and file tables#1954rakeshadr merged 6 commits intoapache:HDDS-2939from
rakeshadr merged 6 commits intoapache:HDDS-2939from
Conversation
linyiqun
reviewed
Feb 23, 2021
Contributor
linyiqun
left a comment
linyiqun
left a comment
There was a problem hiding this comment.
@rakeshadr , haven't taken a deep review for this PR, but catch one thing makes me a little confused.
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
FYI, raised HDDS-4859 jira to handle the back and forth search. |
linyiqun
reviewed
Feb 24, 2021
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreV1.java
Outdated
Show resolved
Hide resolved
rakeshadr
force-pushed
the
HDDS-4683-01
branch
from
55ad376 to
6814a57
Compare
rakeshadr
force-pushed
the
HDDS-4683-01
branch
from
6814a57 to
666e923
Compare
linyiqun
reviewed
Feb 25, 2021
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java
Outdated
Show resolved
Hide resolved
linyiqun
reviewed
Feb 25, 2021
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreV1.java
Outdated
Show resolved
Hide resolved
Contributor
|
@rakeshadr , the PR looks good to me now. Please check above minor comment. |
Contributor
Author
Thanks a lot @linyiqun for the review comments. I will wait for QA report and then merge it. |
rakeshadr
added a commit
that referenced
this pull request
Mar 3, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 9, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 27, 2021
rakeshadr
added a commit
that referenced
this pull request
Apr 7, 2021
rakeshadr
added a commit
that referenced
this pull request
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This task is to perform #listKeys by searching the startKey, keyPrefix in Dir & File Tables.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4683
How was this patch tested?
Added only one UT now. I will add more test cases. I'm thinking something like large dirs and sub-dirs/files.
Also, there is an open point: #listKeys("key-a-"), basically partial keyName and startKey. For example, actual keyName stored in DB are "key-a-10", "key-a-11", "key-a-12"..."key-z-10", "key-z-11", "key-z-12".