HDDS-4969. Extract check dependency installation from Github Actions workflow

[adoroszlai]

What changes were proposed in this pull request?

Move installation of external dependencies for some CI checks from Github Actions workflow to the script of the checks. This reduces complexity of Github-specific code in the workflow definition, and allows simpler prototyping/testing.

https://issues.apache.org/jira/browse/HDDS-4969

How was this patch tested?

https://github.com/adoroszlai/hadoop-ozone/actions/runs/643852771

[adoroszlai]

@elek this is based on your idea from #1984. Installation of spotbugs is not included here because it is still run inside the builder image, which already has the tool.

If this is approved, I'll rebase the other PR.

[elek]

Thanks for the patch @adoroszlai. I have a few suggestions (or more like some questions what I would like to discuss...)

[elek]

I like this one (my local install always has higher priority) but in this case if I have bats on my own PATH, we don't need to download the new one...

I don't know what is the best approach, but we may need to skip the download/install of the binaries if they are already available...

Maybe we can switch to a tool based directory hierarchy (.dev-tools/k3s/...) instead of check based hierarchy (.dev-tools/acceptance/...). It would also help us to reuse tools if they are used from multiple checks. (but with matrix build it may not be required any more...).

Sg. like _install_tool <binary_name> <callback> but you may have a better idea for a good abstraction....

[elek]

Suggested change

	export KUBECONFIG=/etc/rancher/k3s/k3s.yaml
	: ${KUBECONFIG:=/etc/rancher/k3s/k3s.yaml}

Just to support minikube and other users....

[elek]

You can use something like this to avoid sudo:

 virtualenv "${TOOL_DIR}"/robotenv
 source "${TOOL_DIR}"/robotenv/bin/activate
 pip install robotframework

and you can add "${TOOL_DIR}"/robotenv/bin to the path

[elek]

One more comment: we may need to add .dev-tools to .gitignore...

[elek]

+1, thanks the update @adoroszlai

[adoroszlai]

Thanks @elek for reviewing and committing it.