HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.#2140
HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.#2140elek merged 2 commits intoapache:masterfrom
Conversation
mukul1987
left a comment
There was a problem hiding this comment.
We should update the History.md, it is quite old right now. Including it in the current form in the release doesn't makes sense.
@mukul1987 This is a good suggestion, but I disagree with the other statement:
So I think this change is fine in its scope. |
|
Fair point @adoroszlai. Can we please create a followup jira for updating the History.md and other files and mark it as a blocker for 1.2.0 release? I feel if we will update the history by the next release, then we should be good. |
|
Thanks the suggestion @mukul1987, very good point. It seems to be a small update, so I created the patch itself (please see #2149). And agree: as we have PRs for both problems in our radar we can merge the two PRs in any order. |
|
Thanks Marton. +1 for this patch as well. Thanks for updating the file. |
|
Thanks the review @mukul1987 @ayushtkn and @adoroszlai I am merging it after the green build. |
JIRA: https://issues.apache.org/jira/browse/HDDS-5084
What changes were proposed in this pull request?
During the ozone-1.1.0 vote I realized that
HISTORY.md/SECURITY.md/CONTRIBUTING.mdfiles are missing from thebinandsrcartifacts. I think they include very useful information and would be better to include them in the release artifacts.How was this patch tested?