HDDS-4842. Add timestamp to Revoked Certs table in SCM DB#2145
Merged
xiaoyuyao merged 3 commits intoapache:masterfrom Apr 13, 2021
Merged
HDDS-4842. Add timestamp to Revoked Certs table in SCM DB#2145xiaoyuyao merged 3 commits intoapache:masterfrom
xiaoyuyao merged 3 commits intoapache:masterfrom
Conversation
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/SCMDBDefinition.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
Apr 12, 2021
...-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/CertInfo.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
Apr 12, 2021
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
Thanks @vivekratnavel for working on this. The patch LGTM overall. A few comments added inline...
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/SCMDBDefinition.java
Show resolved
Hide resolved
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/SCMDBDefinition.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMCertStore.java
Show resolved
Hide resolved
Contributor
|
@vivekratnavel TestSCMCertStore.testRevokeCertificates failure seems related. |
Contributor
|
Thanks @vivekratnavel for the update. LGTM, +1. I will merge it shortly,. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add timestamp to REVOKED_CERTS table in SCM db.
Instead of modifying the definition of the existing column family, this patch introduces a new column family to make it easier for the finalize upgrade action to support upgrades from older versions.
The changes required to make it backward compatible is tracked here - https://issues.apache.org/jira/browse/HDDS-5088
The changes required to make the persistence happen via Ratis is tracked here - https://issues.apache.org/jira/browse/HDDS-5095
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4842
How was this patch tested?
Unit tests