HDDS-5154. Add SCM GRPC server to publish CRL update.#2216
Merged
vivekratnavel merged 11 commits intoapache:masterfrom Jun 2, 2021
Merged
HDDS-5154. Add SCM GRPC server to publish CRL update.#2216vivekratnavel merged 11 commits intoapache:masterfrom
vivekratnavel merged 11 commits intoapache:masterfrom
Conversation
xiaoyuyao
force-pushed
the
HDDS-5154
branch
2 times, most recently
from
c54a816 to
cebaba9
Compare
xiaoyuyao
force-pushed
the
HDDS-5154
branch
2 times, most recently
from
8c328de to
42dcad3
Compare
...n/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java
Outdated
Show resolved
Hide resolved
Contributor
vivekratnavel
left a comment
vivekratnavel
left a comment
There was a problem hiding this comment.
@xiaoyuyao Thanks for working on this! Overall looks good to me. Minor comments inline.
...framework/src/main/java/org/apache/hadoop/hdds/scm/update/client/CRLClientUpdateHandler.java
Outdated
Show resolved
Hide resolved
...framework/src/main/java/org/apache/hadoop/hdds/scm/update/client/CRLClientUpdateHandler.java
Outdated
Show resolved
Hide resolved
...framework/src/main/java/org/apache/hadoop/hdds/scm/update/client/CRLClientUpdateHandler.java
Show resolved
Hide resolved
...framework/src/main/java/org/apache/hadoop/hdds/scm/update/client/CRLClientUpdateHandler.java
Outdated
Show resolved
Hide resolved
...framework/src/main/java/org/apache/hadoop/hdds/scm/update/client/CRLClientUpdateHandler.java
Outdated
Show resolved
Hide resolved
...erver-scm/src/main/java/org/apache/hadoop/hdds/scm/update/server/SCMUpdateClientManager.java
Outdated
Show resolved
Hide resolved
...erver-scm/src/main/java/org/apache/hadoop/hdds/scm/update/server/SCMUpdateClientManager.java
Outdated
Show resolved
Hide resolved
...erver-scm/src/main/java/org/apache/hadoop/hdds/scm/update/server/SCMUpdateClientManager.java
Outdated
Show resolved
Hide resolved
...r-scm/src/main/java/org/apache/hadoop/hdds/scm/update/server/SCMUpdateServiceGrpcServer.java
Outdated
Show resolved
Hide resolved
...r-scm/src/main/java/org/apache/hadoop/hdds/scm/update/server/SCMUpdateServiceGrpcServer.java
Outdated
Show resolved
Hide resolved
Contributor
|
+1 LGTM. Will merge shortly |
Contributor
|
Just got to this pull request. Glad to see it resolved and merged - Thanks! @swagle @xiaoyuyao @vivekratnavel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add SCM GRPC server to publish CRL update.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5154
How was this patch tested?
UT added.