HDDS-5238. Disable animal-sniffer maven plugin#2253
Merged
adoroszlai merged 3 commits intoapache:masterfrom May 17, 2021
Merged
HDDS-5238. Disable animal-sniffer maven plugin#2253adoroszlai merged 3 commits intoapache:masterfrom
adoroszlai merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks @elek for the improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HDDS-5238
What changes were proposed in this pull request?
animal-sniffer maven plugin can check the API compatibility of the current code with a specific java version.
It's useful when the build uses a JDK (eg. Java 8) which is different from the target JDK (eg. Java 1.6), as it can compare the used Java API signatures with the used ones.
We inherited the plugin execution from the original parent Hadoop pom.xml, but it's not required as we build with Java 8 (and Java 11, but it's not important here) and our target minimum JDK is Java 8.
In the meantime, it's also removed from Hadoop by https://issues.apache.org/jira/browse/HADOOP-15938, as the same functionality (if required) can be achieved by standard javac parameters (see discussion from the Hadoop Jira).
On the other hand, the animal sniffer is slow. Removing it makes the build significant faster:
With master:
With this patch:
It seems to be 46 / 104 -> 44% build time improvement.
How was this patch tested?
Full CI test (+ local builds)