Skip to content

HDDS-5242. Skip failing acceptance suite by default#2263

Merged
elek merged 2 commits intoapache:masterfrom
adoroszlai:HDDS-5242
Jun 2, 2021
Merged

HDDS-5242. Skip failing acceptance suite by default#2263
elek merged 2 commits intoapache:masterfrom
adoroszlai:HDDS-5242

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Acceptance tests are split into a few suites, which can be activated by setting OZONE_ACCEPTANCE_SUITE. CI checks execute 3 splits for faster feedback:

  • secure
  • unsecure
  • misc + anything without suite

There are some other tests, tagged suite:failing, which exist only to test the behavior of the acceptance test runner when failures happen.

The goal of this change is to skip the failing suite by default, i.e. when acceptance tests are run without suite filter. This would allow running all tests in sequence (e.g. in nightly job) while retaining the ability to run these special tests by setting OZONE_ACCEPTANCE_SUITE=failing.

https://issues.apache.org/jira/browse/HDDS-5242

How was this patch tested?

  1. Added bats test case.
  2. Ran test-all.sh with a small tweak to exit after finding tests. The output does not include failing1 or failing2:
    compatibility/test.sh ozone-csi/test.sh ozone-ha/test.sh ozone-mr/test.sh ozone-topology/test.sh ozone/test.sh ozones3-haproxy/test.sh ozonescripts/test.sh ozonesecure-ha/test.sh ozonesecure-mr/test.sh ozonesecure/test.sh restart/test.sh upgrade/test.sh xcompat/test.sh
    
    while on master it does:
    compatibility/test.sh failing1/test.sh failing2/test.sh ozone-csi/test.sh ozone-ha/test.sh ozone-mr/test.sh ozone-topology/test.sh ozone/test.sh ozones3-haproxy/test.sh ozonescripts/test.sh ozonesecure-ha/test.sh ozonesecure-mr/test.sh ozonesecure/test.sh restart/test.sh upgrade/test.sh xcompat/test.sh
    

https://github.com/adoroszlai/hadoop-ozone/runs/2613248841?check_suite_focus=true#step:4:27
https://github.com/adoroszlai/hadoop-ozone/actions/runs/853780974

@adoroszlai adoroszlai self-assigned this May 18, 2021
@adoroszlai adoroszlai changed the title HDDS-5242. Skip failing acceptance suite by default HDDS-5242. Skip failing acceptance suite by default May 18, 2021
Copy link
Copy Markdown
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Sounds reasonable. Thanks the patch @adoroszlai

@elek elek merged commit 183f4b4 into apache:master Jun 2, 2021
@adoroszlai adoroszlai deleted the HDDS-5242 branch June 2, 2021 13:06
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @elek for reviewing and committing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants