HDDS-5242. Skip failing acceptance suite by default#2263
Merged
elek merged 2 commits intoapache:masterfrom Jun 2, 2021
Merged
Conversation
failing acceptance suite by default
elek
approved these changes
Jun 2, 2021
Member
elek
left a comment
There was a problem hiding this comment.
+1. Sounds reasonable. Thanks the patch @adoroszlai
Contributor
Author
|
Thanks @elek for reviewing and committing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Acceptance tests are split into a few suites, which can be activated by setting
OZONE_ACCEPTANCE_SUITE. CI checks execute 3 splits for faster feedback:secureunsecuremisc+ anything withoutsuiteThere are some other tests, tagged
suite:failing, which exist only to test the behavior of the acceptance test runner when failures happen.The goal of this change is to skip the
failingsuite by default, i.e. when acceptance tests are run without suite filter. This would allow running all tests in sequence (e.g. in nightly job) while retaining the ability to run these special tests by settingOZONE_ACCEPTANCE_SUITE=failing.https://issues.apache.org/jira/browse/HDDS-5242
How was this patch tested?
test-all.shwith a small tweak to exit after finding tests. The output does not includefailing1orfailing2:masterit does:https://github.com/adoroszlai/hadoop-ozone/runs/2613248841?check_suite_focus=true#step:4:27
https://github.com/adoroszlai/hadoop-ozone/actions/runs/853780974