HDDS-5168. Use ReplicationConfig in OmKeyArgs#2287
HDDS-5168. Use ReplicationConfig in OmKeyArgs#2287umamaheswararao merged 24 commits intoapache:masterfrom
Conversation
…d0e26b9829a1b529bae5a048ea5f83c13b50' into om-key-args
| return replicationFactor; | ||
| return ReplicationFactor | ||
| .fromProto(ReplicationConfig.getLegacyFactor(replicationConfig)); | ||
| } |
There was a problem hiding this comment.
Maybe we should add a getReplicationConfig() here, as we are deprecating the getType and Factor methods?
There was a problem hiding this comment.
Sure, I added the getter. It's not yet used, but can be useful for users of the Java API.
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
These changes LGTM. I had just one comment on a missing getter. It would be good to add it, but its not essential right now.
|
Changes looks good to me. I see. I think currently deprecated APIs used in the place where we may want to use getReplicationConfig API. I think thats ok for now? they are existing calls already( to deprecated APIs) and eventually new usage required to add that API(getReplicationConfig) and use it. If we wanted to add now, thats ok too. Thanks |
|
Thanks the review @sodonnel and @umamaheswararao
@umamaheswararao Can you please add some examples: I see examples where |
3 participants
What changes were proposed in this pull request?
During the implementation of HDDS-5145 I realized that OmKeyArgs also uses factor/type, it seems to be easier to convert it to replicationConfig as it's an in-memory class not a protobuf which is required to be persisted.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5168
How was this patch tested?
Full CI test.