HDDS-5285. Document block deleting service classes#2296
Merged
cku328 merged 2 commits intoapache:masterfrom Jun 9, 2021
Merged
HDDS-5285. Document block deleting service classes#2296cku328 merged 2 commits intoapache:masterfrom
cku328 merged 2 commits intoapache:masterfrom
Conversation
jojochuang
reviewed
Jun 7, 2021
|
|
||
| /** | ||
| * TODO: javadoc. | ||
| * DeletedBlockLogStateManager interface to provide BlocksTransaction |
Contributor
There was a problem hiding this comment.
I think we can make this more verbose.
if you trace the code, you'll find it ultimately writes to SCMMetadataStore.getDeletedBlocksTXTable() which says "A Table that keeps the deleted blocks lists and transactions."
You might say it's an interface to manage deleted blocks and record them in the underlying persist store.
Contributor
Author
There was a problem hiding this comment.
This seems to be a good proposal, let me revise it.
cku328
approved these changes
Jun 9, 2021
Contributor
cku328
left a comment
cku328
left a comment
There was a problem hiding this comment.
+1 Thanks @sky76093016 for the update.
jojochuang
approved these changes
Jun 9, 2021
Contributor
|
PR merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add class-level javadoc for DeletedBlockLogStateManager and DeletedBlockLogStateManagerImpl.
What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5285
How was this patch tested?
No test.