HDDS-5316. Fix datanode reserved space calculation.#2310
Merged
ChenSammi merged 3 commits intoapache:masterfrom Jun 15, 2021
Merged
HDDS-5316. Fix datanode reserved space calculation.#2310ChenSammi merged 3 commits intoapache:masterfrom
ChenSammi merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@ChenSammi @bshashikant please help review this, thanks~ |
Contributor
|
Thanks @guihecheng for working on this. The patch LGTM. Can you please add a unit test for the space calculation? |
Contributor
Author
|
@ChenSammi sure, will add more tests, thanks~ |
Contributor
Author
|
@ChenSammi updated with more tests, thanks~ |
Contributor
|
+1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This tries to fix the datanode reserved space calculation, details in the issue description and code comments.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5316
How was this patch tested?
new UTs.