HDDS-5318. Intermittent failure in TestOzoneManagerDoubleBufferWithOMResponse#2314
Merged
adoroszlai merged 2 commits intoapache:masterfrom Jun 9, 2021
Merged
HDDS-5318. Intermittent failure in TestOzoneManagerDoubleBufferWithOMResponse#2314adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
hanishakoneru
approved these changes
Jun 8, 2021
Contributor
Author
|
Thanks @hanishakoneru for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestOzoneManagerDoubleBufferWithOMResponseis flaky because double buffer involves another thread.flushTransactionsupdatesflushedTransactionCount, then somewhat later also updateslastAppliedIndex. The test waits for the former, but simply checks the latter with assertion. We need to wait for this update, too.https://issues.apache.org/jira/browse/HDDS-5318
How was this patch tested?
Repeated
TestOzoneManagerDoubleBufferWithOMResponse50x:https://github.com/adoroszlai/hadoop-ozone/runs/2771888499
Regular CI (pending):
https://github.com/adoroszlai/hadoop-ozone/actions/runs/918284218