HDDS-5307. Remove checkAclRight method, duplicates checkAclRights#2323
Merged
xiaoyuyao merged 3 commits intoapache:masterfrom Jun 11, 2021
Merged
HDDS-5307. Remove checkAclRight method, duplicates checkAclRights#2323xiaoyuyao merged 3 commits intoapache:masterfrom
xiaoyuyao merged 3 commits intoapache:masterfrom
Conversation
…and checkAclRight seem to implement the same thing
adoroszlai
changed the title
xiaoyuyao
approved these changes
Jun 11, 2021
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
LGTM, +1. Thanks @pakapoj-tul for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
deprecate all checkAclRight method since the implementation is the same between checkAclRight and checkAclRights
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5307
How was this patch tested?
I deployed HDDS-5307 on my dev cluster, tested manually by Create/Read/Delete, baremetal deployment, working fine IMO