HDDS-5349. Avoid usage of locks in listStatus.#2369
HDDS-5349. Avoid usage of locks in listStatus.#2369bharatviswa504 merged 12 commits intoapache:masterfrom
Conversation
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
Thanks @bharatviswa504 for the contribution. Added a few comments, pls take a look at it.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
bharatviswa504
force-pushed
the
HDDS-5349
branch
from
30bfa57 to
921fed6
Compare
cxorm
left a comment
cxorm
left a comment
There was a problem hiding this comment.
Thanks @bharatviswa504 for the description of it in jira,
the changes look well with the existing CI, I'm +1.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
|
/pending How about moving the BUCKET_LOCK in PREFIX layout |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Marking this issue as un-mergeable as requested.
Please use /ready comment when it's resolved.
Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)
How about moving the BUCKET_LOCK in PREFIX layout
|
/ready |
github-actions
bot
dismissed
their stale review
Blocking review request is removed.
…ne/om/KeyManagerImpl.java Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
bharatviswa504
force-pushed
the
HDDS-5349
branch
from
d3a66f5 to
ecf77a1
Compare
|
@rakeshadr Fixed review comments. |
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
+1 LGTM, thanks @bharatviswa504 for the contribution.
|
Thank You @rakeshadr for the review and offline discussion. |
4 participants
What changes were proposed in this pull request?
Avoid usage of locks when iterating rocksdb iterator.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5349
How was this patch tested?
Existing UT's.