HDDS-5174. EC: Allow EC blocks to be requested from OM#2414
Merged
umamaheswararao merged 2 commits intoapache:HDDS-3816-ecfrom Jul 26, 2021
Merged
HDDS-5174. EC: Allow EC blocks to be requested from OM#2414umamaheswararao merged 2 commits intoapache:HDDS-3816-ecfrom
umamaheswararao merged 2 commits intoapache:HDDS-3816-ecfrom
Conversation
sodonnel
changed the title
umamaheswararao
approved these changes
Jul 19, 2021
Contributor
umamaheswararao
left a comment
umamaheswararao
left a comment
There was a problem hiding this comment.
Changes looks straightforward to me.
We also discussed, testing allocate block without making server calls is not easy. we can be tested as part of full write path test.
| break; | ||
| case EC: | ||
| requestBuilder.setEcReplicationConfig( | ||
| ((ECReplicationConfig)replicationConfig).toProto()); |
Contributor
There was a problem hiding this comment.
Looks like we missed break here. Sorry missed this in previous review.
Contributor
There was a problem hiding this comment.
Since this is merged, Let's handle in next patch.
Contributor
Author
There was a problem hiding this comment.
Ah. Well spotted. I will create a small patch today to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow EC block requests to propagate from OM to SCM, as currently only STANDALONE and RATIS are supported.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5174
How was this patch tested?
Existing tests.