HDDS-3740. PipelineStateManagerV2Impl#removePipeline will remove pipeline from db in case of failure#2415
Merged
ChenSammi merged 2 commits intoapache:masterfrom Jul 19, 2021
Merged
Conversation
added 2 commits
July 14, 2021 20:05
…line from db in case of failure
Contributor
|
LGTM，+1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When PipelineStateManagerV2Impl#removePipeline is called, we are removing the pipeline from db and then making the call to pipelineStateMap#removePipeline.
pipelineStateMap#removePipeline can throw an exception if it's not able to remove the pipeline, this will leave the db in inconsistent state.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3740
How was this patch tested?
unit test