HDDS-5054. Merge SCM HA configs to ScmConfigKeys.

[aswinshakil]

What changes were proposed in this pull request?

To Merge SCM HA Configuration into ScmConfigKeys and remove unused configurations.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5054

How was this patch tested?

The patch was tested using Unit tests, Integration tests and Acceptance tests using GitHub CI.

https://github.com/aswinshakil/ozone/actions/runs/1099362111

[vivekratnavel]

Can we add appropriate prefixes to identify the keys easier?

For instance, this can be renamed to OZONE_SCM_HA_RATIS_RPC_TYPE. All the other configs can also be prefixed with "OZONE_SCM_HA"

[vivekratnavel]

We can remove these tests as they aren't meaningful.

[avijayanhwx]

Thanks for working on this Aswin!

A question for @bshashikant / @GlenGeng. Was the objective to move all the configs in SCM HA config to the old method of declaring configs (through ozone-default)? Or do we want to create a single SCMConfiguration class of type ConfigGroup that has all the configs from both the old files?

[bshashikant]

Thanks for working on this Aswin!

A question for @bshashikant / @GlenGeng. Was the objective to move all the configs in SCM HA config to the old method of declaring configs (through ozone-default)? Or do we want to create a single SCMConfiguration class of type ConfigGroup that has all the configs from both the old files?

I am ok with either of the approaches.

[avijayanhwx]

LGTM +1, pending CI

[vivekratnavel]

Merging this since TestBlockDeletion test is flaky - https://issues.apache.org/jira/browse/HDDS-5605