HDDS-5496. Missing directory name in start_k8s_env log#2545
Merged
adoroszlai merged 2 commits intoapache:masterfrom Sep 13, 2021
Merged
HDDS-5496. Missing directory name in start_k8s_env log#2545adoroszlai merged 2 commits intoapache:masterfrom
start_k8s_env log#2545adoroszlai merged 2 commits intoapache:masterfrom
Conversation
ayushtkn
approved these changes
Aug 23, 2021
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Shows up in the build:
https://github.com/apache/ozone/pull/2545/checks?check_run_id=3350460528#step:5:124 https://github.com/apache/ozone/pull/2545/checks?check_run_id=3350460528#step:5:294 https://github.com/apache/ozone/pull/2545/checks?check_run_id=3350460528#step:5:438 https://github.com/apache/ozone/pull/2545/checks?check_run_id=3350460528#step:5:610
Changes LGTM
Member
|
This can be merged, @adoroszlai waiting for someones review? |
Contributor
Author
|
Thanks @ayushtkn for the review. |
sadanand48
pushed a commit
that referenced
this pull request
Oct 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix missing directory name in messages like:
Print path in
start_k8s_envinstead of expecting it to be passed (as it is not). Current dir can be used because test execution requirescdto test dir anyway.https://issues.apache.org/jira/browse/HDDS-5496
How was this patch tested?
Verified log in CI run:
https://github.com/adoroszlai/hadoop-ozone/runs/3349882860#step:5:124
https://github.com/adoroszlai/hadoop-ozone/runs/3349882860#step:5:318
https://github.com/adoroszlai/hadoop-ozone/runs/3349882860#step:5:461
https://github.com/adoroszlai/hadoop-ozone/runs/3349882860#step:5:629