HDDS-5611. Fixed NullPointerException in ContainerStateMachine during Pipeline Close.#2548
Merged
avijayanhwx merged 4 commits intoapache:masterfrom Aug 26, 2021
Merged
Conversation
Contributor
|
Thanks @aswinshakil for report the issue and fix it. I left several comments inline. |
ChenSammi
reviewed
Aug 18, 2021
...r-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerController.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Aug 18, 2021
...r-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerController.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Aug 18, 2021
...r-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerController.java
Show resolved
Hide resolved
avijayanhwx
approved these changes
Aug 26, 2021
Contributor
|
Acceptance (misc) failure seems unrelated. |
Contributor
|
Thanks for the fix @aswinshakil and the review @ChenSammi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To fix the NullPointerException when markContainerForClose method is invoked. The exception is caused when we access the getContainerState method for a container object which is null.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5611
How was this patch tested?
The patch was tested with Unit tests and GitHub CI test.
https://github.com/aswinshakil/ozone/runs/3345654012
The integration test TestPipelineClose.testPipelineCloseWithLogFailure is failing due to some issue with flaky tests. Attached the jira for that issue here.
https://issues.apache.org/jira/browse/HDDS-5626