HDDS-5707. List container supports replication factor filter.#2606
Merged
captainzmc merged 6 commits intoapache:masterfrom Oct 27, 2021
Merged
HDDS-5707. List container supports replication factor filter.#2606captainzmc merged 6 commits intoapache:masterfrom
captainzmc merged 6 commits intoapache:masterfrom
Conversation
JacksonYao287
approved these changes
Sep 3, 2021
Contributor
JacksonYao287
left a comment
JacksonYao287
left a comment
There was a problem hiding this comment.
LGTM +1, thanks for the work @ChenSammi
Comment on lines
411
to
427
Contributor
There was a problem hiding this comment.
maybe we can refactor the codes as below, i think it will make the logic more clear and efficient!
if (state == null){
if(factor == null){
.............
} else{
............
}
}else{
if(factor == null){
...........
} else{
.......
}
}
Contributor
Author
There was a problem hiding this comment.
Thanks @JacksonYao287 for the code review. I will update a new commit later to addres the comments.
ChenSammi
force-pushed
the
HDDS-5707
branch
from
8ccbeaf to
bb7d098
Compare
ChenSammi
force-pushed
the
HDDS-5707
branch
from
3a6b4bc to
dde626e
Compare
Member
|
Merged this, thanks @ChenSammi ‘ patch, and thanks @JacksonYao287 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-5707