HDDS-5477 : EC: commit key should consolidate and create one keyLocationInfo per blockGrp#2648
Merged
sodonnel merged 4 commits intoapache:HDDS-3816-ecfrom Sep 16, 2021
Merged
Conversation
sodonnel
approved these changes
Sep 15, 2021
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
+1 from me. However I would really like us to add tests for this specific area. I know there is a plan to refactor the ECBlockOutputStream classes and at that time I think we should ensure we have some tests for this, as the data written to OM is so important.
…mitKey in mockOmTransport
Contributor
Author
|
@sodonnel Thanks for the review. I have added a test to validate commitKey info. I figured out that client was not sending in sorted order. Anyway while reading you would do that based on index order. However I have just did simple sort to send them in correct order. |
Contributor
|
Thanks for adding the tests etc. This change LGTM and has passed all checks so I will go ahead and commit it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Consolidates the block stream information per the block group.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5477
How was this patch tested?
To check current tests impact.