HDDS-5741. EC: Remove hard coded chunksize and get from from ReplicationConfig#2687
Merged
sodonnel merged 3 commits intoapache:HDDS-3816-ecfrom Oct 4, 2021
Merged
Conversation
Contributor
umamaheswararao
left a comment
umamaheswararao
left a comment
There was a problem hiding this comment.
Thanks for the patch @sodonnel . I have just dropped few minor comments. Please take a look. Thanks
| .setOmClient(ozoneManagerClient).setRequestID(requestId) | ||
| .setReplicationConfig(openKey.getKeyInfo().getReplicationConfig()) | ||
| .setReplicationConfig(( | ||
| (ECReplicationConfig)openKey.getKeyInfo().getReplicationConfig())) |
Contributor
There was a problem hiding this comment.
Nit: we can remove redundant brackets.
| private int ecChunkSize; | ||
| private final int numDataBlks; | ||
| private final int numParityBlks; | ||
| private static final ByteBufferPool BUFFER_POOL = new ElasticByteBufferPool(); |
Contributor
There was a problem hiding this comment.
Below there is a hardcodec codec name. You may want to take it from replication config?
private static final String DEFAULT_CODEC_NAME = "rs";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The EC Chunksize is currently hard coded in ECBlockInputStream and ECBlockOutputStream. Now that ECReplicationConfig carries the chunkSize and codec, we can remove these hardcoded values.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5741
How was this patch tested?
Existing tests