HDDS-5800. Bucket usedByte was incorrect when deleting duplicate keys.#2696
Merged
Conversation
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
+1 LGTM.
Good catch.
Contributor
|
Thank You @captainzmc for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When we repeatedly write a key and then delete the key. We should count all versions of the key and subtract them from bucket usedBytes.
Previously we only subtracted the key size of the last version, which resulted in inaccurate bucket usedBytes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5800
How was this patch tested?
UT added