HDDS-6066. Cleanup OmService injection.#2896
Merged
bharatviswa504 merged 4 commits intoapache:masterfrom Dec 10, 2021
Merged
Conversation
kerneltime
reviewed
Dec 7, 2021
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
Show resolved
Hide resolved
Contributor
|
One minor suggestion. LGTM |
Contributor
|
@bharatviswa504 if you wish to do the further clean up in a separate jira that is fine as well. |
Contributor
Author
Thanks, We have a Jira HDDS-4010 which touches the same related code. I will revisit this as part of HDDS-4010 Jira. |
Contributor
Author
|
@kerneltime |
Contributor
|
LGTM. It would be nice to remove |
Contributor
|
Thanks @bharatviswa504 for working on this and @kerneltime for reviewing it. |
Contributor
Author
|
Thank You @hanishakoneru and @kerneltime for the review. |
JacksonYao287
pushed a commit
to JacksonYao287/ozone
that referenced
this pull request
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cleanup OmService Injection.
With the proposal of HDDS-5881, S3G is not using S3 Tokens for auth, it is using S3G Kerberos credential plus token information is now part of actual Proto OMRequest Object. After this change, we do not need service field which we inject for tokens.
And also old code has issue, when one of the address is unresolved it fails injection. (Now anyway this code is not needed, we should be good)
What is the link to the Apache JIRA
[(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)](https://issues.apache.org/jira/browse/HDDS-6066)
How was this patch tested?
Existing tests. This is mostly removal of not required code.