Skip to content

HDDS-6107. Exclude hugo lock file from source tarball#2923

Merged
errose28 merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-6107
Dec 14, 2021
Merged

HDDS-6107. Exclude hugo lock file from source tarball#2923
errose28 merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-6107

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Hugo 0.89:

Hugo now writes an empty file named .hugo_build.lock to the root of the project when building

We should exclude this lock file from the source tarball of releases.

$ mvn -DskipTests -Psrc clean package
$ tar tzvf hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT-src.tar.gz | grep hugo | wc -l
       1

https://issues.apache.org/jira/browse/HDDS-6107

How was this patch tested?

$ mvn -DskipTests -Psrc clean package
$ tar tzvf hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT-src.tar.gz | grep hugo | wc -l
       0

@adoroszlai adoroszlai self-assigned this Dec 14, 2021
@adoroszlai adoroszlai requested a review from errose28 December 14, 2021 20:54
Copy link
Copy Markdown
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @adoroszlai. I verified with mvn clean install -Dmaven.javadoc.skip=true -DskipTests -Pdist,src -Dtar that the hugo lock file was not present in the output source tarball.

@errose28 errose28 merged commit 47cd204 into apache:master Dec 14, 2021
errose28 pushed a commit that referenced this pull request Dec 15, 2021
@adoroszlai adoroszlai deleted the HDDS-6107 branch December 15, 2021 06:47
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @errose28 for reviewing and committing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants