Skip to content

HDDS-5807. [FSO] Merge HDDS-4653 changes to support TDE for MPU Keys in FSO bucket layout.#2941

Merged
rakeshadr merged 7 commits intoapache:masterfrom
JyotinderSingh:HDDS-5807
Dec 23, 2021
Merged

HDDS-5807. [FSO] Merge HDDS-4653 changes to support TDE for MPU Keys in FSO bucket layout.#2941
rakeshadr merged 7 commits intoapache:masterfrom
JyotinderSingh:HDDS-5807

Conversation

@JyotinderSingh
Copy link
Contributor

What changes were proposed in this pull request?

This task is to merge HDDS-4653 to support Transparent Data Encryption for MPU Keys in FSO bucket layout.

Presently it's throwing a NOT_SUPPORTED exception.

10:01:29.283 [OM StateMachine ApplyTransaction Thread - 0] ERROR OMAudit - user=xyz | ip=127.0.0.1 | op=INITIATE_MULTIPART_UPLOAD {volume=d05a32f8-29a0-46f3-9215-d3b8ace658c5, bucket=dcdf3716-970d-4e66-a6ba-f857d9311aa7, key=mpu_test_key_1, dataSize=0, replicationType=STAND_ALONE, replicationFactor=ONE} | ret=FAILURE

org.apache.hadoop.ozone.om.exceptions.OMException: MultipartUpload is not yet supported on encrypted buckets
at org.apache.hadoop.ozone.om.request.s3.multipart.S3InitiateMultipartUploadRequestWithFSO.validateAndUpdateCache(S3InitiateMultipartUploadRequestWithFSO.java:120)
...

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5807

How was this patch tested?

Related integration tests.

Copy link
Contributor

@rakeshadr rakeshadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work @JyotinderSingh. I've added few comments, please take care.

@JyotinderSingh
Copy link
Contributor Author

Thanks for the reviews @rakeshadr. I have addressed the comments.

@bharatviswa504
Copy link
Contributor

Thank You @JyotinderSingh for taking this up, I have HDDS-5940 opened for the similar issue, I will close that out.

Copy link
Contributor

@rakeshadr rakeshadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @JyotinderSingh for the contribution. I will merge it shortly.

@rakeshadr rakeshadr merged commit 9dc63a3 into apache:master Dec 23, 2021
@JyotinderSingh JyotinderSingh deleted the HDDS-5807 branch December 23, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants