HDDS-5807. [FSO] Merge HDDS-4653 changes to support TDE for MPU Keys in FSO bucket layout.#2941
Merged
rakeshadr merged 7 commits intoapache:masterfrom Dec 23, 2021
Merged
Conversation
added 2 commits
December 22, 2021 13:31
…in FSO bucket layout.
rakeshadr
reviewed
Dec 22, 2021
...p-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Dec 22, 2021
...-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequestWithFSO.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Dec 22, 2021
Contributor
rakeshadr
left a comment
There was a problem hiding this comment.
Good Work @JyotinderSingh. I've added few comments, please take care.
Contributor
Author
|
Thanks for the reviews @rakeshadr. I have addressed the comments. |
Contributor
|
Thank You @JyotinderSingh for taking this up, I have HDDS-5940 opened for the similar issue, I will close that out. |
rakeshadr
reviewed
Dec 23, 2021
...-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequestWithFSO.java
Outdated
Show resolved
Hide resolved
rakeshadr
approved these changes
Dec 23, 2021
Contributor
rakeshadr
left a comment
There was a problem hiding this comment.
+1 LGTM, thanks @JyotinderSingh for the contribution. I will merge it shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This task is to merge HDDS-4653 to support Transparent Data Encryption for MPU Keys in FSO bucket layout.
Presently it's throwing a NOT_SUPPORTED exception.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5807
How was this patch tested?
Related integration tests.