HDDS-6287. BlockDeletingService add inDeleting Container condition

[guohao-rosicky]

What changes were proposed in this pull request?

BlockDeletingService add inDeleting Container condition

The container that is being deleted does not participate in container selection, preventing worker threads from holding locks for a long time

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6287

[errose28]

Thanks for working on this @guohao-rosicky. My understanding is that the current background service implementation could allow more container delete tasks to be kicked off for an overlapping container set before the current ones have finished (if the current ones take a very long time), and that is why code was added to track containers currently under deletion.

To me it would seem more intuitive to have BackgroundService block until its current set of tasks have finished or timed out before adding new ones, since I don't think any of Ozone's background services can effectively handle overlapping executions. However, this behavior was explicitly changed in HDDS-4231, so maybe @lokeshj1703 can provide some insight as to why the background service was changed in this way.

The current BackgroundService implementation seems a bit dangerous to me as nothing is enforcing the timeout and overlapping runs on the same data will break child classes. FWIW Java's ScheduledFuture#scheduleWithFixedDelay defines the interval as being between the end of one task and the start of another, so the BackgroundService is using a somewhat non-standard definition for interval here I would say.

[lokeshj1703]

@guohao-rosicky Thanks for working on this! Can you please provide more info on the problem and how inDeleting containers are involved?

[adoroszlai]

/pending please provide more info on the problem

[github-actions]

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

please provide more info on the problem

[github-actions]

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."