HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()#3117
Closed
kaijchen wants to merge 1 commit intoapache:HDDS-3816-ecfrom
Closed
HDDS-6354. EC: Fix allocateBlockIfFull condition in ECKeyOutputStream#write()#3117kaijchen wants to merge 1 commit intoapache:HDDS-3816-ecfrom
kaijchen wants to merge 1 commit intoapache:HDDS-3816-ecfrom
Conversation
guihecheng
reviewed
Feb 21, 2022
| off += ecChunkSize; | ||
| iters--; | ||
| checkAndWriteParityCells(pos, iters > 0 || remLen > 0); | ||
| checkAndWriteParityCells(pos, iters > 0 || lastCellSize > 0); |
Contributor
There was a problem hiding this comment.
This should be a good catch.
LGTM+1
Member
Author
Contributor
|
Thanks @kaijchen for reporting and @guihecheng for the initial review. |
Member
Author
|
Closed because of #3120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remLen > 0will always be true if thiswhileloop ever gets entered.I think it's intended to be
lastCellSize > 0.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6354
How was this patch tested?
N/A