HDDS-6435. Add read lock waiting and held time metrics#3180
Merged
rakeshadr merged 11 commits intoapache:masterfrom Apr 5, 2022
Merged
HDDS-6435. Add read lock waiting and held time metrics#3180rakeshadr merged 11 commits intoapache:masterfrom
rakeshadr merged 11 commits intoapache:masterfrom
Conversation
rakeshadr
reviewed
Mar 11, 2022
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/lock/LockManager.java
Show resolved
Hide resolved
rakeshadr
reviewed
Mar 11, 2022
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Mar 11, 2022
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java
Outdated
Show resolved
Hide resolved
rakeshadr
approved these changes
Mar 15, 2022
Contributor
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
+1 LGTM Thanks @tanvipenumudy for the useful contribution!
adoroszlai
reviewed
Mar 16, 2022
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for updating the patch.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
adoroszlai
requested changes
Mar 20, 2022
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for updating the patch. Can you please also check the concurrency problem?
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Apr 4, 2022
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for updating the patch, LGTM.
Contributor
|
Thanks @tanvipenumudy for the useful contribution and continuous efforts! Thanks a lot @adoroszlai for pointing out potential issues during reviews and the patch came really well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To provide useful information by exposing read lock waiting, held time metrics and log messages to understand OzoneManagerLock timestamp such as:
longestReadLockWaitingTime: longest time (ms) a read lock was waiting since the last measurementlongestReadLockHeldTime: longest time (ms) a read lock was held since the last measurementnumReadLockLongWaiting: number of times the read lock has been waiting longer than the default threshold configurationnumReadLockLongHeld: number of times the read lock has been held longer than the default threshold configurationWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6435
How was this patch tested?
Added JUnit tests.