Skip to content

HDDS-6472. Errors in TestOzoneContainer integration test#3216

Merged
adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai:HDDS-6472
Mar 23, 2022
Merged

HDDS-6472. Errors in TestOzoneContainer integration test#3216
adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai:HDDS-6472

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • Tests using mini cluster tried to start 3 datanodes with the same fixed port. Only start one datanode.
  • runTestOzoneContainerViaDataNode and testCloseContainer had leftover assertions after HDDS-5359, which removed delete chunk/block requests
  • Disable testBothGetandPutSmallFile, which is failing due to HDDS-6473, not a test bug.

https://issues.apache.org/jira/browse/HDDS-6472

How was this patch tested?

50x runs of TestOzoneContainer:
https://github.com/adoroszlai/hadoop-ozone/runs/5620046984

Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2013240882

@adoroszlai adoroszlai self-assigned this Mar 21, 2022
@adoroszlai adoroszlai added bug Something isn't working test labels Mar 21, 2022
@adoroszlai adoroszlai requested a review from ayushtkn March 22, 2022 08:53
@adoroszlai
Copy link
Contributor Author

Thanks @ayushtkn for the review. Updated the PR with changes based on that.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoroszlai adoroszlai merged commit 2f2f525 into apache:master Mar 23, 2022
@adoroszlai adoroszlai deleted the HDDS-6472 branch March 23, 2022 17:42
@adoroszlai
Copy link
Contributor Author

Thanks again @ayushtkn for the review. I will file a PR for HDDS-6473 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants