HDDS-6362. Add aggregate metrics to ContainerBalancerMetrics#3239
HDDS-6362. Add aggregate metrics to ContainerBalancerMetrics#3239lokeshj1703 merged 3 commits intoapache:masterfrom
Conversation
|
@lokeshj1703 @JacksonYao287 @symious Can you please review? |
lokeshj1703
left a comment
lokeshj1703
left a comment
There was a problem hiding this comment.
@siddhantsangwan Thanks for working on this! The changes look good to me. Few comments inline.
|
|
||
| @Metric(about = "Total data size in GB moved across all iterations of " + | ||
| "Container Balancer.") | ||
| private MutableCounterLong totalSizeMovedGB; |
There was a problem hiding this comment.
Rename to dataSizeMovedGB
|
|
||
| @Metric(about = "Total number of container moves across all iterations of " + | ||
| "Container Balancer.") | ||
| private MutableCounterLong totalNumContainerMoves; |
There was a problem hiding this comment.
Rename to numContainerMoves since we already have inLatestIteration suffix.
|
@siddhantsangwan Thanks for the patch. Can we add a metrics to record the failed moves of containers? Sometimes it might be helpful to track some issues. |
|
@lokeshj1703 @symious Thanks for reviewing. I'm planning to add a metric for failed moves in this jira: https://issues.apache.org/jira/browse/HDDS-6492 |
# Conflicts: # hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
lokeshj1703
left a comment
lokeshj1703
left a comment
There was a problem hiding this comment.
@siddhantsangwan Thanks for updating the PR! The changes look good to me. +1.
3 participants
What changes were proposed in this pull request?
Add aggregate metrics such as total number of container moves and total size moved across all the iterations of Container Balancer. Currently, only metrics specific to an iteration are present.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6362
How was this patch tested?
Existing UTs. An integration test or manual testing will be more comprehensive.