HDDS-6375. [Multi-Tenant] Implement tenant request metrics#3256
Merged
smengcl merged 7 commits intoapache:HDDS-4944from Apr 13, 2022
Merged
HDDS-6375. [Multi-Tenant] Implement tenant request metrics#3256smengcl merged 7 commits intoapache:HDDS-4944from
smengcl merged 7 commits intoapache:HDDS-4944from
Conversation
Change-Id: Ib0990ebc46786a53e921ec3abd638264f2d381b2
Change-Id: I51297e716da28e5186de244bcaeaf2a80af7c164
Change-Id: Icb95707e93b96d33b1aeff01c7a56735f3ccf8d4
Conflicts: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantCreateRequest.java Change-Id: I5d05ce3ee0b8762caa866faa2d6029f25ab1f43c
Contributor
Author
|
@aswinshakil Would you take a look at the patch? Thx! |
Change-Id: Ic685946e31c6530a17d51f02caaba136e9f00c29
aswinshakil
reviewed
Apr 12, 2022
Member
aswinshakil
left a comment
aswinshakil
left a comment
There was a problem hiding this comment.
Overall LGTM, I have added a few comments. Thanks for working on this @smengcl.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
Show resolved
Hide resolved
...anager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantDeleteRequest.java
Show resolved
Hide resolved
...anager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantDeleteRequest.java
Show resolved
Hide resolved
…ere for other requests (just do ALL minus fails) Change-Id: I9581fd681f5742c417674166266113f044c376b8
Conflicts: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantAssignAdminRequest.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantRevokeAdminRequest.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantRevokeUserAccessIdRequest.java Change-Id: I49a59cc2a65a978c230ddfd3953383c1ca00075f
aswinshakil
reviewed
Apr 13, 2022
aswinshakil
approved these changes
Apr 13, 2022
Contributor
Author
|
Thanks @aswinshakil for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement tenant request metrics for all tenant operations.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6375
How was this patch tested?