HDDS-6436. Add write lock waiting and held time metrics#3271
Merged
rakeshadr merged 7 commits intoapache:masterfrom Apr 8, 2022
Merged
HDDS-6436. Add write lock waiting and held time metrics#3271rakeshadr merged 7 commits intoapache:masterfrom
rakeshadr merged 7 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Hi @JyotinderSingh, @siddhantsangwan, @rakeshadr it would be great if you can review the patch, thanks! |
rakeshadr
reviewed
Apr 7, 2022
Contributor
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
Thanks @tanvipenumudy for the contribution. Added a few comments, please go through it.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 7, 2022
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 7, 2022
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 7, 2022
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 7, 2022
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 8, 2022
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java
Outdated
Show resolved
Hide resolved
rakeshadr
approved these changes
Apr 8, 2022
Contributor
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
+1 LGTM. Thanks @tanvipenumudy for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To provide useful information by exposing write lock waiting, held time metrics to understand OzoneManagerLock timestamp
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6436
How was this patch tested?
Added UTs