Skip to content

Conversation

@symious
Copy link
Contributor

@symious symious commented Apr 19, 2022

What changes were proposed in this pull request?

In HDDS-6562, we introduced the feature to exclude specific operations for AuditLog.

But the usage in PROD cluster is not convenient, we need to update the config and restart service to enable the new configuration.

This ticket is to add a new servlet to refresh the configuration for AuditLog.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6603

How was this patch tested?

unit test.

@symious
Copy link
Contributor Author

symious commented Apr 19, 2022

@adoroszlai @dineshchitlangia @arp7 @ferhui Could you help to review this PR?

@swamirishi
Copy link
Contributor

@symious Can you add a testcase enabling debug operations dynamically? Correct me if I am wrong I dont see this in this PR.

Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@symious The Audit Log implementation is done via log4j2 which supports dynamic refresh via the log4j2 configuration as shown below.
# Checks for config change periodically and reloads
monitorInterval=5

Check example log config file below:
HDDS/test/Auditlog.properties

Can you please add more details if you faced issue with audit log config change in production environment?

@symious
Copy link
Contributor Author

symious commented Jan 31, 2023

@dineshchitlangia Thank you for the advice, the reload feature works fine for our cases, I will close this ticket.

@symious symious closed this Jan 31, 2023
@dineshchitlangia
Copy link
Contributor

@symious Glad that it works for you! Thank you for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants