HDDS-6606. Rat check failure ignored for ozone-annotation-processing

[adoroszlai]

What changes were proposed in this pull request?

• Collect rat failures from the new dev-support/annotations directory, too.
• Add missing license header.
• Reduce duplication by looping over the dirs to be checked.

https://issues.apache.org/jira/browse/HDDS-6606

How was this patch tested?

Verified that the check properly fails due to license violation:

$ ./hadoop-ozone/dev-support/checks/rat.sh
...
dev-support/annotations/target/rat.txt: !????? src/main/java/org/apache/ozone/annotations/package-info.java

Then added the missing header and re-ran the check:

$ ./hadoop-ozone/dev-support/checks/rat.sh
...

$ echo $?
0

https://github.com/adoroszlai/hadoop-ozone/runs/6081893903

[fapifta]

Thank you @adoroszlai for this improvement, and catching the fact that I missed to add the results of rat in the annotation-processing module to the output of the whole check, with that missing the license info in the package-info file...

I think the changes are great, and makes it more simpler to extend, while it is also easier to overview what is happening. +1

[adoroszlai]

Thanks @fapifta for the kind review.