HDDS-6647. Tag some known flaky tests#3349
Merged
adoroszlai merged 1 commit intoapache:masterfrom Apr 26, 2022
Merged
Conversation
adoroszlai
reviewed
Apr 26, 2022
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @kaijchen for adding these tags.
I think the title "Tag some known flaky tests" would better reflect the change. "Address" may imply fixing the tests.
| * since fs.rename(src,dst,options) is enabled. | ||
| */ | ||
| @Test | ||
| @Flaky("HDDS-6646") |
Contributor
There was a problem hiding this comment.
@Flaky requires JUnit5-based tests. TestOzoneFileSystem and its siblings are still on JUnit4, because they are heavily parameterized and need a significant refactoring (see HDDS-6152).
We can add these tags, but expect the tests to be included in the non-flaky runs and not repeated in case of failure.
kaijchen
changed the title
adoroszlai
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added flaky tag to some tests.
HDDS-6335. TestParentAcl#testKeyAcl
https://github.com/apache/ozone/runs/6168965490?check_suite_focus=true#step:5:1859
HDDS-5819, HDDS-6451. TestRootedOzoneFileSystem#testRenameToTrashEnabled
https://github.com/kaijchen/ozone/runs/6151453278?check_suite_focus=true#step:4:3038
HDDS-6477, HDDS-6642. TestOzoneManagerHAMetadataOnly#testListVolumes:
https://github.com/kaijchen/ozone/runs/6150362670?check_suite_focus=true#step:4:3142
HDDS-6644. TestOzoneManagerHAMetadataOnly#testReadRequest:
https://github.com/kaijchen/ozone/runs/6150362734?check_suite_focus=true#step:4:3558
HDDS-6645. TestOzoneFileSystem#testTrash
https://github.com/kaijchen/ozone/runs/6150521370?check_suite_focus=true#step:4:2934
HDDS-6646. TestOzoneFileSystem#testRenameToTrashEnabled
https://github.com/kaijchen/ozone/runs/6150521445?check_suite_focus=true#step:4:3454
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6647
How was this patch tested?
CI