HDDS-6641. datanode usageinfo CLI should provide JSON output option#3356
Merged
adoroszlai merged 2 commits intoapache:masterfrom Apr 29, 2022
Merged
HDDS-6641. datanode usageinfo CLI should provide JSON output option#3356adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Apr 28, 2022
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sodonnel for the improvement. LGTM, with one minor suggestion for the test.
...dds/tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestUsageInfoSubcommand.java
Show resolved
Hide resolved
adoroszlai
approved these changes
Apr 29, 2022
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sodonnel for updating the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the option for the command
ozone admin datanode usageinfoto output as JSON/What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6641
How was this patch tested?
New unit tests. Also verified the JSON out using a docker-compose cluster: