HDDS-6689. New checkstyle: NoLineWrap#3378
Closed
kaijchen wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
7df8b2b to
2487985
Compare
Contributor
|
Thanks @kaijchen for the patch. I think it's a nice improvement. However, there are a few feature branches out there, some planned to be merged soon. I would like to avoid causing conflicts or failures for them due to this change. So let's re-visit this once those branches are merged. |
Member
Author
|
Thanks @adoroszlai for the comments. Actually I'm closing this for the same reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add new checkstyle rule
NoLineWrap, which checks no line wrap inpacakge,importandstatic importstatements.https://checkstyle.sourceforge.io/config_whitespace.html#NoLineWrap
Fix violations by running the following command multiple times.
P.S. Each iteration changes
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6689
How was this patch tested?
Existing CI.