HDDS-6827. Need proper error message when "RATIS" replication-type is passed with EC codec#3491
Merged
adoroszlai merged 6 commits intoapache:masterfrom Jun 8, 2022
Merged
Conversation
adoroszlai
reviewed
Jun 8, 2022
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @kaijchen for working on this.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Member
Author
|
Thanks @adoroszlai for the review. |
adoroszlai
approved these changes
Jun 8, 2022
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @kaijchen for updating the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See https://issues.apache.org/jira/browse/HDDS-6827
How was this patch tested?
Integration test and acceptance test.
Manual test: