HDDS-7151. Avoid using GeneratedMessage in non-generated code#3699
Merged
adoroszlai merged 2 commits intoapache:masterfrom Aug 23, 2022
Merged
HDDS-7151. Avoid using GeneratedMessage in non-generated code#3699adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
kerneltime
reviewed
Aug 19, 2022
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/CodecRegistry.java
Show resolved
Hide resolved
kerneltime
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GeneratedMessageis Protobuf implementation detail and should not be used by non-generated code. Replace with usage of theMessageinterface. This is in preparation of Protobuf upgrade, since Protobuf 3 generatesGeneratedMessageV3instead.https://issues.apache.org/jira/browse/HDDS-7151
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2889775897