HDDS-7159. Run integration tests on Java 8#3708
Merged
adoroszlai merged 1 commit intoapache:masterfrom Aug 23, 2022
Merged
Conversation
kerneltime
reviewed
Aug 22, 2022
| maven-repo-${{ hashFiles('**/pom.xml') }} | ||
| maven-repo- | ||
| - name: Setup java | ||
| uses: actions/setup-java@v1 |
Contributor
There was a problem hiding this comment.
Question: Looks like there are newer versions with better support for other JDKs and there is also https://github.com/oracle-actions/setup-java
Contributor
Author
There was a problem hiding this comment.
We can check upgrade to v2 or v3 separately. I don't know if using oracle-actions is OK or not for Apache.
Member
There was a problem hiding this comment.
We can switch to setup-java@v3 later. And the temurin distribution seems more neutral.
kerneltime
approved these changes
Aug 22, 2022
Contributor
Author
|
Thanks @kaijchen, @kerneltime for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #3707: run integration tests on Java 8.
TestSecureOzoneClusteris failing on Java 11.https://issues.apache.org/jira/browse/HDDS-7159
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/7957021440?check_suite_focus=true