HDDS-7286. Clean up ContainerManager

[myskov]

What changes were proposed in this pull request?

Clean up of org.apache.hadoop.hdds.scm.container.ContainerManager and its descendants. Removed various code smells such as

• using deprecated methods
• missing javadocs
• using methods annotated VisibleForTesting in production code

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7286

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

Unit tests

[Galsza]

Minor nitpicking, otherwise looking good to me

[Galsza]

@myskov Please try to avoid force-push when updating the PR. Here are some great articles that explain why:

https://developers.mattermost.com/blog/submitting-great-prs/#4-avoid-force-pushing
https://www.freecodecamp.org/news/optimize-pull-requests-for-reviewer-happiness#request-a-review

[myskov]

@Galsza, I did a force-push to retrigger verifications due to a flaky test. Is it possible to permit contributors to retrigger verifications?

[Galsza]

I think you either have to ask a committer to restart the pipeline, or add a commit with very small changes. @adoroszlai this is the two best practice, right?

[adoroszlai]

@myskov Committers can retrigger via Github, which allows rerunning only failed jobs. So the best way for contributors is to ping one or more committers. Otherwise, you can retrigger by any further commit, even an empty one:

git commit --allow-empty -m 'trigger new CI check'
git push

[myskov]

@Galsza could you merge the PR, please?

[myskov]

@adoroszlai please take a look at the PR

[kaijchen]

LGTM, thanks @myskov for the work.