HDDS-7323. Recon: Auto refresh toggle is switched back when visiting new site#3868
Merged
smengcl merged 5 commits intoapache:masterfrom Nov 10, 2022
Merged
HDDS-7323. Recon: Auto refresh toggle is switched back when visiting new site#3868smengcl merged 5 commits intoapache:masterfrom
smengcl merged 5 commits intoapache:masterfrom
Conversation
Contributor
Contributor
|
cc @duongkame |
dombizita
reviewed
Oct 27, 2022
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for the patch @smitajoshi12, overall it looks good to me and it is working as expected. I added an inline comment which suggests to not create a new method, rather use the already existing autoReloadToggleHandler and add that one line of code there.
...-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/autoReloadHelper.tsx
Outdated
Show resolved
Hide resolved
…ew site new Review Changes
…ew site Space Issue
…ew site Space Issue Suggested by Zita
Contributor
|
Thanks for updating your patch @smitajoshi12, it looks good to me! |
smengcl
reviewed
Nov 8, 2022
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @smitajoshi12 . The latest approach looks much cleaner. One last nit on the const/var name
...n/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx
Outdated
Show resolved
Hide resolved
...n/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx
Outdated
Show resolved
Hide resolved
...-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/autoReloadHelper.tsx
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Nov 10, 2022
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @smitajoshi12 for the patch. Thanks @dombizita for reviewing this.
smengcl
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Auto Reload toggle on and off should be in sync with Datanode, Pipeline and Overview Page.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7323
How was this patch tested?
Manually